Fixed bug for relative URIs in app dev#6891
Conversation
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
b863bc8 to
e585544
Compare
Coverage report
Test suite run success3785 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from e3e7335 |
jantnovi
left a comment
There was a problem hiding this comment.
Approving the change now because this is the current blessed way to do this sort of transformation, but I think longer term the team would like to be more explicit with transformation interfaces we provide. This is especially true given our impending move to JSON contracts for module validation and given that we want to push as much logic to the backend as possible. Will discuss that internally, but for now this won't block our immediate plans so lgtm.
Merge activity
|
0f68d33 to
88de2a7
Compare
88de2a7 to
e3e7335
Compare
|
🤖 Code Review · #projects-dev-ai for questions 🚫 PR closed 📋 History🚫 PR closed |


closes: https://github.com/shop/issues-event-foundations/issues/793
WHY are these changes introduced?
During development, webhook events need to be delivered to the local development server through a tunnel URL. Previously, relative URIs in event subscriptions were not being resolved, causing webhook delivery failures.
WHAT is this pull request doing?
Implements URI resolution for event subscriptions by modifying
transformFromEventsConfigto prepend theapplication_urlto relative URIs (those starting with/). Absolute URIs remain unchanged. The transformation handles edge cases including missing configuration, trailing slashes in application URLs, and empty subscription arrays.How to test your changes?
/webhooks/orders)