Conversation
This comment has been minimized.
This comment has been minimized.
app initapp init
|
Will need to figure out why unit tests are failing. Works on my machine ™️. |
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251120104339Caution After installing, validate the version by running just |
Coverage report
Test suite run success3797 tests passing in 1450 suites. Report generated by 🧪jest coverage report action from 8941db3 |
250ba03 to
94b8275
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Converted PR to Draft to avoid merging before required server-side changes. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/environment.d.ts@@ -53,7 +53,7 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
/**
* If true, the CLI should not use the Partners API.
*
- * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ * @returns True when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set.
*/
export declare function blockPartnersAccess(): boolean;
/**
|
94b8275 to
37f0070
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
|
Still relevant. |
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
|
Should we merge this now that we have app limits? |
dmerand
left a comment
There was a problem hiding this comment.
I have a few automated review follow-ups that might clean this up since it hasn't shipped yet.
Review assisted by pair-review
c717875 to
d94dde8
Compare
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - No issues 📋 History✅ 1 findings → ✅ No issues |
1530d5b to
05b8645
Compare
c1af9a6 to
b2ab286
Compare
05b8645 to
31f6457
Compare
31f6457 to
319d1e2
Compare
b2ab286 to
6651656
Compare
319d1e2 to
8941db3
Compare

WHY are these changes introduced?
The
app initcommand has interactive prompts that are impossible to bypass. This prevents scripting and some agentic use.(Agentic use may still be difficult as the agent needs to obtain the organization ID, but this puts us a step closer.)
WHAT is this pull request doing?
organization-idflag to suppress organization selectionnameflag suppresses interactive linking and name promptsinitcommandSHOPIFY_FLAG_CLIENT_IDenvironment definition in our GitHub actions to the acceptance test job specifically (where it's needed), since it was breaking the newapp inittestsHow to test your changes?
The following commands should all be successful:
The following should fail:
Measuring impact
How do we know this change was effective? Please choose one:
Checklist