[py] moved static method get_path to SeleniumManager class#12554
[py] moved static method get_path to SeleniumManager class#12554sandeepsuryaprasad wants to merge 1 commit intoSeleniumHQ:trunkfrom
get_path to SeleniumManager class#12554Conversation
|
I believe we want to leave it as it is because we want to have more things in DriverFinder. cc @titusfortner One thing I would appreciate is that an issue is raised before a PR like this is created. Changes like this should be discussed and therefore avoid unnecessary work. We are also in Slack if you want to discuss things you'd like to work on. |
|
I'm seeing some value in the Ruby side to making SeleniumManager class a lighter wrapper of the binary, and putting more of the driver finding logic into the DriverFinder class, like this - #12429 Not sure if it is the right direction; we should discuss |
|
While I would agree with the sentiment that having a class with one static method is better written as a function, I think it's totally fine if we want to namespace these functions into a class as opposed to a separate module. But either way is fine, and the class way gives use more flexibility in the future if we want to add state, or other functionality. |
|
I'm closing this in favor of #13387 |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved the static method
get_pathfromDriverFinderclass incommon/driver_finder.pytoSeleniumManagerclass incommon/selenium_manager.py.Motivation and Context
get_pathtoSeleniumManagerclass itself. So thatdriver_finder.pyandDriverFinderclass could be eliminated.SeleniumManager.Types of changes
Checklist