Conversation
Sayrix
requested changes
Jul 12, 2023
Sayrix
left a comment
Sayrix
left a comment
Owner
There was a problem hiding this comment.
For the followUp can you add the error to the /locales ?
Collaborator
Author
|
Alr, should I just google translate it for other lang? |
Owner
|
No just add it in english and let translators to translate it |
Sayrix
approved these changes
Jul 12, 2023
Collaborator
Author
Alr, next time, I'll just fill those with english. The issue with leaving it empty is that the bot will throw error if it tries to pull the empty locale (if the user switch to a non-default file). |
Owner
|
Yeah, maybe use a better i18n thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some code refactoring to clear out some random eslint warnings and added
questions/ticketTypeslength check so the bot will force the user to fix it.