feat: Version Checks#154
Conversation
|
Hi i don't think that doing a git show is good because people can not have git |
|
Oh, ur tutorial shows git clone to get the project, so I assume everyone will be doing that, making git available. |
|
Yeah but sometimes they just download the zip in the releases page and upload them in a vps that don't have git or into a pterodactyl container |
|
Welp, I'm not sure if there's any other way that doesn't involve adding version tags manually. We could also only support such check if the user has git. |
|
In the package.json |
|
And then you can make a request to github to get the latest release in https://github.com/Sayrix/Ticket-Bot/releases |
Sayrix
left a comment
There was a problem hiding this comment.
Use another method instead of using git
|
Oh, you keep versions there. That works, I'll just modify some stuff on my end then. |
|
REST-API based version check is done |
Sayrix
left a comment
There was a problem hiding this comment.
Not tested but the code seems to be ok, can you ask to someone to try your code or just say me if you tested it ?
|
works pretty good. |
|
Thank you very much for your contribution |
Resolves #152 by comparing remote and local git hashes.