Skip to content

feat: Version Checks#154

Merged
Sayrix merged 3 commits into
Sayrix:mainfrom
zhiyan114:main
Jun 16, 2023
Merged

feat: Version Checks#154
Sayrix merged 3 commits into
Sayrix:mainfrom
zhiyan114:main

Conversation

@zhiyan114

Copy link
Copy Markdown
Collaborator

Resolves #152 by comparing remote and local git hashes.

@Sayrix

Sayrix commented Jun 16, 2023

Copy link
Copy Markdown
Owner

Hi i don't think that doing a git show is good because people can not have git

@zhiyan114

Copy link
Copy Markdown
Collaborator Author

Oh, ur tutorial shows git clone to get the project, so I assume everyone will be doing that, making git available.

@Sayrix

Sayrix commented Jun 16, 2023

Copy link
Copy Markdown
Owner

Yeah but sometimes they just download the zip in the releases page and upload them in a vps that don't have git or into a pterodactyl container

@zhiyan114

Copy link
Copy Markdown
Collaborator Author

Welp, I'm not sure if there's any other way that doesn't involve adding version tags manually.

We could also only support such check if the user has git.

@Sayrix

Sayrix commented Jun 16, 2023

Copy link
Copy Markdown
Owner

In the package.json

@Sayrix

Sayrix commented Jun 16, 2023

Copy link
Copy Markdown
Owner

And then you can make a request to github to get the latest release in https://github.com/Sayrix/Ticket-Bot/releases

@Sayrix Sayrix left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use another method instead of using git

@zhiyan114

Copy link
Copy Markdown
Collaborator Author

Oh, you keep versions there. That works, I'll just modify some stuff on my end then.

@zhiyan114 zhiyan114 marked this pull request as draft June 16, 2023 15:33
@zhiyan114 zhiyan114 marked this pull request as ready for review June 16, 2023 15:57
@zhiyan114

zhiyan114 commented Jun 16, 2023

Copy link
Copy Markdown
Collaborator Author

REST-API based version check is done

@Sayrix Sayrix left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but the code seems to be ok, can you ask to someone to try your code or just say me if you tested it ?

@zhiyan114

Copy link
Copy Markdown
Collaborator Author

works pretty good.

@Sayrix Sayrix merged commit 5d24597 into Sayrix:main Jun 16, 2023
@Sayrix

Sayrix commented Jun 16, 2023

Copy link
Copy Markdown
Owner

Thank you very much for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect bot updates automatically

2 participants