Open
Conversation
betinacosta
reviewed
Apr 7, 2026
betinacosta
reviewed
Apr 7, 2026
betinacosta
reviewed
Apr 7, 2026
betinacosta
reviewed
Apr 7, 2026
jeanscherf
requested changes
Apr 7, 2026
Member
jeanscherf
left a comment
There was a problem hiding this comment.
The gen/ directory contains generated *_pb2.py files but there are no .proto source files checked in. Without the sources no one can regenerate or update the generated code.
-
Add proto source files to src/sap_cloud_sdk/core/auditlog_ng/proto/ with a
buf.yaml and buf.gen.yaml that configure output into gen/ and src/buf/.
(really liked buf btw! Thanks for the suggestion!). -
Also add a Makefile at the repo root with at minimum:
.PHONY: proto
proto:
cd src/sap_cloud_sdk/core/auditlog_ng/proto && buf generate
- Add .github/workflows/proto-verify.yml that runs
make protoand thengit diff --exit-codeto fail the PR if generated files differ.
Let me know if you need any help with all that.
jeanscherf
reviewed
Apr 8, 2026
jeanscherf
reviewed
Apr 8, 2026
jeanscherf
reviewed
Apr 8, 2026
Co-authored-by: Jean Scherf <jeanscherf@gmail.com>
jeanscherf
reviewed
Apr 8, 2026
jeanscherf
approved these changes
Apr 9, 2026
Member
jeanscherf
left a comment
There was a problem hiding this comment.
Great work! Thank you for the contribution!
LGTM
betinacosta
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new auditlog_ng client for the SAP Cloud SDK for Python.
The new client enables sending Audit Log Service NG (v3) events over OTLP/gRPC and is designed for integration into Python services and agents.
What’s included
Usage
Example:
Testing
Added unit tests under tests/core/unit/auditlog_ng