Open
Conversation
DMS integration
…dmin operation and then added then integration test for DMS
Add CMIS retrieval and user APIs for DMS module
added enums for hash algo, cache eviction, and remove todo comments
|
|
Contributor
|
Update README |
NicoleMGomes
requested changes
Apr 6, 2026
NicoleMGomes
reviewed
Apr 6, 2026
betinacosta
reviewed
Apr 7, 2026
src/sap_cloud_sdk/dms/__init__.py
Outdated
|
|
||
|
|
||
| def create_client( | ||
| *, instance: Optional[str] = None, dms_cred: Optional[DMSCredentials] = None |
Member
There was a problem hiding this comment.
I believe we need to have _telemetry_source: Optional[Module] = None here in create_client for telemetry.
NicoleMGomes
reviewed
Apr 8, 2026
| CLOUD_SDK_CFG_DESTINATION_DEFAULT_IDENTITYZONE=your-identity-zone-here | ||
|
|
||
| CLOUD_SDK_CFG_SDM_DEFAULT_URI=https://your-sdm-api-uri-here | ||
| CLOUD_SDK_CFG_SDM_DEFAULT_UAA='{"url":"https://your-auth-url","clientid":"your-client-id","clientsecret":"your-client-secret","identityzone":"your-identity-zone"}' |
Contributor
There was a problem hiding this comment.
Better to have multiple variables for it, we have faced some issues in the past
Member
Author
There was a problem hiding this comment.
we thought of keeping it similar to how these variables are defined in the actual mount path in kyma runtime, should we keep the structure of env variables different that the mount?
screenshot of mount below
NicoleMGomes
reviewed
Apr 8, 2026
| ) -> None: | ||
| """Initialise a DMSClient. | ||
|
|
||
| Args: |
Contributor
There was a problem hiding this comment.
Check other clients, put warning to use create_client instead of direct constructor
FIX: added warning for direct client creation and completed flow for …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR aims to add sap document mangement service functionality in the python cloud sdk
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following: