rust: update FileOperations to use arbitrary type from PointerWrapper.#387
Merged
wedsonaf merged 1 commit intoRust-for-Linux:rustfrom Jun 23, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
wedsonaf
force-pushed
the
file-operations
branch
from
3f23080 to
72dbac4
Compare
This comment has been minimized.
This comment has been minimized.
TheSven73
reviewed
Jun 22, 2021
wedsonaf
force-pushed
the
file-operations
branch
from
72dbac4 to
fed6785
Compare
This comment has been minimized.
This comment has been minimized.
Author
v1 -> v2
|
TheSven73
approved these changes
Jun 23, 2021
Collaborator
TheSven73
left a comment
TheSven73
left a comment
There was a problem hiding this comment.
LGTM after this gets rebased.
…per`. This allows `FileOperations` implementers to have arbitrary (wrapped) values as `private_data` (as opposed to only wrapped `Self`). It also allows wrappers to dictate the borrowed type. For now all wrappers of `T` just borrow `&T`, but in a subsequent PR `Ref<T>` will borrow to `&Ref<T>`, which allows implementations to increment the refcount. Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
wedsonaf
force-pushed
the
file-operations
branch
from
fed6785 to
2117c9f
Compare
Member
|
Review of
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
FileOperationsimplementers to have arbitrary (wrapped)values as
private_data(as opposed to only wrappedSelf).It also allows wrappers to dictate the borrowed type. For now all
wrappers of
Tjust borrow&T, but in a subsequent PRRef<T>willborrow to
&Ref<T>, which allows implementations to increment therefcount.
This is based on #386.
Signed-off-by: Wedson Almeida Filho wedsonaf@google.com