This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Add github flavored markdown table implementation.#12
Merged
Robpol86 merged 1 commit intoRobpol86:masterfrom Oct 17, 2015
Merged
Add github flavored markdown table implementation.#12Robpol86 merged 1 commit intoRobpol86:masterfrom
Robpol86 merged 1 commit intoRobpol86:masterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
@Robpol86 CI warns for this issue: W:106, 4: __init__ method from base class 'BaseTable' is not called (super-init-not-called), but I think there is no need to call the super here.
Owner
There was a problem hiding this comment.
You should still stick super() it in there.
bcho
force-pushed
the
features/github-flavored-table
branch
from
31c6038 to
e55cf1e
Compare
Robpol86
added a commit
that referenced
this pull request
Oct 17, 2015
Add github flavored markdown table implementation.
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this implementation will disable the usage of title.