Skip to content

Wait for browser approval on resume#845

Merged
RhysSullivan merged 4 commits into
mainfrom
codex/resume-waits-for-browser-approval
May 18, 2026
Merged

Wait for browser approval on resume#845
RhysSullivan merged 4 commits into
mainfrom
codex/resume-waits-for-browser-approval

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

@RhysSullivan RhysSullivan commented May 18, 2026

Summary

  • make browser-approval resume wait for the user decision instead of immediately re-returning the approval URL
  • add local/cloud approval waiters and wake pending resume calls from the approval endpoint
  • update the model-facing pause instructions to tell the agent to show the URL, then call resume

Tests

  • bun run test src/server.test.ts (packages/hosts/mcp)
  • bun run test src/server/mcp-browser-resume.test.ts (apps/local)

Stack

  1. Handle missing dynamic tool calls #846
  2. Wait for browser approval on resume #845 👈 current

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing b3482e8 Commit Preview URL

Branch Preview URL
May 18 2026, 06:55 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud b3482e8 May 18 2026, 06:55 PM

@RhysSullivan RhysSullivan force-pushed the codex/resume-waits-for-browser-approval branch from d2956b8 to 29f15b8 Compare May 18, 2026 03:16
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 18, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@845

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@845

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@845

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@845

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@845

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@845

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@845

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@845

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@845

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@845

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@845

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@845

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@845

executor

npm i https://pkg.pr.new/executor@845

commit: b3482e8

@RhysSullivan RhysSullivan force-pushed the codex/resume-waits-for-browser-approval branch 2 times, most recently from d566461 to 0b0da86 Compare May 18, 2026 03:32
@RhysSullivan RhysSullivan changed the title Fix browser approval resume flow Wait for browser approval on resume May 18, 2026
@RhysSullivan RhysSullivan changed the base branch from main to codex/tool-resolution-errors May 18, 2026 03:32
@RhysSullivan RhysSullivan force-pushed the codex/resume-waits-for-browser-approval branch 2 times, most recently from da6d55b to 2a75346 Compare May 18, 2026 17:30
@RhysSullivan RhysSullivan changed the base branch from codex/tool-resolution-errors to main May 18, 2026 18:54
@RhysSullivan RhysSullivan force-pushed the codex/resume-waits-for-browser-approval branch from 2a75346 to b3482e8 Compare May 18, 2026 18:54
@RhysSullivan RhysSullivan merged commit 8f87860 into main May 18, 2026
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant