Skip to content

[codex] Clean up OpenAPI add source API#843

Merged
RhysSullivan merged 5 commits into
mainfrom
codex/openapi-add-api-notes
May 18, 2026
Merged

[codex] Clean up OpenAPI add source API#843
RhysSullivan merged 5 commits into
mainfrom
codex/openapi-add-api-notes

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • Cleans up the OpenAPI add-source API around explicit URL/blob spec input and explicit source identity fields.
  • Removes add-payload targetScope and credentialTargetScope in favor of route scope plus binding writes.
  • Updates the add-source UI to write credential values through source bindings, including spec-fetch credentials.

Validation

  • bunx tsc --noEmit --pretty false -p packages/plugins/openapi/tsconfig.json
  • bunx vitest run --config vitest.config.ts src/sdk/plugin.test.ts
  • bunx vitest run --config vitest.node.config.ts src/services/sources-refresh.node.test.ts
  • bunx vitest run --config vitest.node.config.ts src/services/sources-api.node.test.ts
  • bunx vitest run --config vitest.node.config.ts src/services/tenant-isolation.node.test.ts

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 17, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing f389a0c Commit Preview URL

Branch Preview URL
May 18 2026, 12:13 AM

@RhysSullivan RhysSullivan force-pushed the codex/openapi-add-api-notes branch from d7127bb to ac41c99 Compare May 17, 2026 19:38
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 17, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud f389a0c May 18 2026, 12:14 AM


const makeMinimalOpenApiSourcePayload = (
targetScope: ScopeId,
_targetScope: ScopeId,
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont have unused variables

value: "alice-secret",
},
});
const binding = yield* client.openapi.setSourceBinding({
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we were removing the explicit set source binding function in favor of better dx, chat with me on this


const makeTenantOpenApiSourcePayload = (
targetScope: ScopeId,
_targetScope: ScopeId,
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no unused

}
}

const specInputForAdd = (input: string) => {
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use effect try

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 17, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@843

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@843

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@843

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@843

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@843

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@843

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@843

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@843

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@843

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@843

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@843

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@843

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@843

executor

npm i https://pkg.pr.new/executor@843

commit: f389a0c

@RhysSullivan RhysSullivan force-pushed the codex/openapi-add-api-notes branch from 0aaa676 to a43182a Compare May 17, 2026 19:49
@RhysSullivan RhysSullivan marked this pull request as ready for review May 18, 2026 00:19
@RhysSullivan RhysSullivan merged commit 529a54f into main May 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant