[codex] Clean up OpenAPI add source API#843
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | f389a0c | Commit Preview URL Branch Preview URL |
May 18 2026, 12:13 AM |
d7127bb to
ac41c99
Compare
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | f389a0c | May 18 2026, 12:14 AM |
RhysSullivan
commented
May 17, 2026
|
|
||
| const makeMinimalOpenApiSourcePayload = ( | ||
| targetScope: ScopeId, | ||
| _targetScope: ScopeId, |
Owner
Author
There was a problem hiding this comment.
dont have unused variables
RhysSullivan
commented
May 17, 2026
| value: "alice-secret", | ||
| }, | ||
| }); | ||
| const binding = yield* client.openapi.setSourceBinding({ |
Owner
Author
There was a problem hiding this comment.
i thought we were removing the explicit set source binding function in favor of better dx, chat with me on this
RhysSullivan
commented
May 17, 2026
|
|
||
| const makeTenantOpenApiSourcePayload = ( | ||
| targetScope: ScopeId, | ||
| _targetScope: ScopeId, |
RhysSullivan
commented
May 17, 2026
| } | ||
| } | ||
|
|
||
| const specInputForAdd = (input: string) => { |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
0aaa676 to
a43182a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation