Skip to content

[codex] Add browser approval flow for resumed executions#842

Merged
RhysSullivan merged 1 commit into
mainfrom
codex/browser-resume-approval-flow
May 17, 2026
Merged

[codex] Add browser approval flow for resumed executions#842
RhysSullivan merged 1 commit into
mainfrom
codex/browser-resume-approval-flow

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • Route model-facing MCP resume through signed-in browser approval by default, with allow_model_resume=true preserving the old model-side resume path.
  • Add local and cloud /resume/:executionId approval pages, including cloud MCP session Durable Object lookup via mcp_session_id with owner validation.
  • Show structured pending request details and schema-aware approval fields instead of CLI-oriented raw pause text.
  • Keep managed MCP elicitation flows inline and hide resume when clients support elicitation.

Validation

  • bun run --cwd packages/react typecheck
  • bun run --cwd packages/core/execution typecheck
  • bun run --cwd packages/hosts/mcp typecheck
  • bun run --cwd packages/hosts/mcp test
  • bun run --cwd apps/cloud typecheck
  • bun run --cwd apps/cloud vite build
  • bun run --cwd apps/local build
  • git diff --check

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 17, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud a1028ed May 17 2026, 08:00 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 17, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing a1028ed Commit Preview URL

Branch Preview URL
May 17 2026, 08:00 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 17, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@842

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@842

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@842

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@842

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@842

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@842

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@842

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@842

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@842

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@842

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@842

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@842

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@842

executor

npm i https://pkg.pr.new/executor@842

commit: a1028ed

@RhysSullivan RhysSullivan force-pushed the codex/browser-resume-approval-flow branch 13 times, most recently from 3ceee02 to d0539e8 Compare May 17, 2026 18:59
Comment thread apps/cli/src/main.ts Outdated
Comment thread apps/cli/src/main.ts Outdated
@RhysSullivan RhysSullivan force-pushed the codex/browser-resume-approval-flow branch from d0539e8 to 57fb6e7 Compare May 17, 2026 19:08
Comment thread apps/cloud/src/auth/handlers.ts Outdated
Comment thread packages/core/api/src/handlers/executions.ts Outdated
Comment thread packages/react/src/pages/resume-approval.tsx
Comment thread packages/react/src/components/mcp-install-card.tsx
Comment thread packages/react/src/components/elicitation-approval.tsx
Comment thread packages/app/src/routes/resume.$executionId.tsx Outdated
Comment thread apps/local/src/server/mcp.ts Outdated
Comment thread apps/local/src/server/mcp.ts Outdated
@RhysSullivan RhysSullivan force-pushed the codex/browser-resume-approval-flow branch from 57fb6e7 to b7b559a Compare May 17, 2026 19:28
@RhysSullivan RhysSullivan force-pushed the codex/browser-resume-approval-flow branch from b7b559a to a1028ed Compare May 17, 2026 19:59
@RhysSullivan RhysSullivan marked this pull request as ready for review May 17, 2026 20:24
@RhysSullivan RhysSullivan merged commit 1d16b0b into main May 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant