Skip to content

Fix crash on variadic tool path arguments#761

Merged
RhysSullivan merged 2 commits into
RhysSullivan:mainfrom
grfwings:variadic-path-fix
May 11, 2026
Merged

Fix crash on variadic tool path arguments#761
RhysSullivan merged 2 commits into
RhysSullivan:mainfrom
grfwings:variadic-path-fix

Conversation

@grfwings
Copy link
Copy Markdown
Contributor

Fixes #738

Effect CLI currently requires an explicit options object for Argument.variadic; without it, the parsed pathParts value
becomes {} instead of an array. That made executor call ... crash before invoking the tool.

This updates the call command to parse path segments with:

  Args.string("tool-path-segment").pipe(Args.variadic({}))

and adds an explicit failure if the parser ever returns a non-array value.

Upstream issue: Effect-TS/effect#6228

Also, added .pi/ to .gitignore.

@RhysSullivan RhysSullivan merged commit 205c3d6 into RhysSullivan:main May 11, 2026
6 checks passed
@RhysSullivan
Copy link
Copy Markdown
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

executor call crashes because variadic path args do not have .at

2 participants