Added shade_kwargs to utils.mountain_plot().#122
Merged
TomGeorge1234 merged 1 commit intoRatInABox-Lab:mainfrom Feb 5, 2025
Merged
Added shade_kwargs to utils.mountain_plot().#122TomGeorge1234 merged 1 commit intoRatInABox-Lab:mainfrom
TomGeorge1234 merged 1 commit intoRatInABox-Lab:mainfrom
Conversation
Collaborator
|
Sorry, I forgot about this but just merged. Thanks again!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #121 enabling users to pass keyword arguments to the
fill_between()function used for shading inutils.mountain_plot(). As a result, users can control the shading properties more closely.For instance, this provides an easy way for users to circumvent the pyplot issue whereby exported plots with a lot of
fill_between()shading produce very large and even truncated vector files. Until this issue is fixed, this problem can be circumvented by adding"rasterized": Truetoshade_kwargs, such that the shading specifically is converted to a pixel image instead of being saved as a very large set of vectors.