feat: add MiniMax as a supported LLM provider#3666
Open
octo-patch wants to merge 3 commits intoQuivrHQ:mainfrom
Open
feat: add MiniMax as a supported LLM provider#3666octo-patch wants to merge 3 commits intoQuivrHQ:mainfrom
octo-patch wants to merge 3 commits intoQuivrHQ:mainfrom
Conversation
Add MiniMax (https://www.minimax.io/) as a first-class LLM provider, enabling users to leverage MiniMax-M2.5 and MiniMax-M2.5-highspeed models (204K context window) through their OpenAI-compatible API. Changes: - Add MINIMAX to DefaultModelSuppliers enum - Register MiniMax-M2.5 and MiniMax-M2.5-highspeed model configs - Add MiniMax handler in LLMEndpoint using ChatOpenAI with base_url https://api.minimax.io/v1 - Add unit test for MiniMax endpoint creation - Update README to list MiniMax among supported providers Usage: Set MINIMAX_API_KEY environment variable, then configure: supplier: "minimax" model: "MiniMax-M2.5"
9d22fcf to
09e07d7
Compare
- Add MiniMax-M2.7 and MiniMax-M2.7-highspeed to model list - Place M2.7 models before M2.5 in config for priority - Keep all previous models (M2.5, M2.5-highspeed) as alternatives - Update test to use M2.7 and add model config verification test
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="core/quivr_core/rag/entities/config.py">
<violation number="1" location="core/quivr_core/rag/entities/config.py:280">
P2: `"MiniMax-M2.7-highspeed"` config is unreachable via `get_llm_model_config` because `"MiniMax-M2.7"` appears first in the dict and matches via `startswith`. Swap the order so the longer (more specific) key is checked first.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Put MiniMax-M2.7-highspeed before MiniMax-M2.7 (and similarly for M2.5) in the _model_defaults dict so that the more specific key is matched first by the startswith lookup in get_llm_model_config.
Author
|
Good catch! Swapped the dict ordering so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiniMax-M2.5andMiniMax-M2.5-highspeedmodels (204K context window, up to 192K output tokens)https://api.minimax.io/v1)Details
MiniMax offers OpenAI-compatible chat completion APIs. This PR adds MiniMax as a dedicated supplier in Quivr's
DefaultModelSuppliersenum, with proper model configs and endpoint handling viaChatOpenAI.Supported Models
MiniMax-M2.5MiniMax-M2.5-highspeedUsage
export MINIMAX_API_KEY=your_api_keyTest plan
Files changed
core/quivr_core/rag/entities/config.py- Add MINIMAX enum + model configscore/quivr_core/llm/llm_endpoint.py- Add MiniMax handlercore/tests/test_llm_endpoint.py- Add MiniMax testREADME.md- Update supported providers list