Skip to content

Proposition uniqueness enforced by representation#109

Merged
haz merged 12 commits into
QuMuLab:mainfrom
connoralittle:main
Sep 4, 2024
Merged

Proposition uniqueness enforced by representation#109
haz merged 12 commits into
QuMuLab:mainfrom
connoralittle:main

Conversation

@connoralittle

Copy link
Copy Markdown
Collaborator

First attempt at Issue #108
Passes test I made

@connoralittle connoralittle linked an issue Aug 28, 2024 that may be closed by this pull request
3 tasks
Comment thread issue_test.py Outdated
Comment thread issue_test.py Outdated
Comment thread bauhaus/core.py Outdated
Comment thread bauhaus/core.py Outdated
Comment thread bauhaus/core.py Outdated
Comment thread bauhaus/core.py Outdated
@connoralittle

Copy link
Copy Markdown
Collaborator Author

test_core temporarily does not work, will have to be fixed

@haz

haz commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

This still on your radar, @connoralittle ?

@connoralittle

Copy link
Copy Markdown
Collaborator Author

Do the changes I made in the last push work? The changes for test-core I haven't done but can get tonight. I think it was broken before my changes and so will have to be partially rewritten.

@haz

haz commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Ah, I missed the Outdated flag on the comments. So just the test-core now.

@connoralittle

Copy link
Copy Markdown
Collaborator Author

I must have been mistaken, it seems to work with the changes and no rewrite.

Comment thread bauhaus/core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
Comment thread tests/test_core.py Outdated
@haz haz merged commit ab3002b into QuMuLab:main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Proposition Uniqueness

2 participants