You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I must have missed this from #1514 - what's the purpose of the PYO3_CROSS env var? It's not documented; it looks like #1514 introduced this, but it doesn't do anything special except force cross compilation. However at least PYO3_CROSS_LIB_DIR is also required at the same time, so it doesn't seem that there's a point to having a separate PYO3_CROSS variable...
I must have missed this from #1514 - what's the purpose of the PYO3_CROSS env var?
Oh, I think I was using that so that I could ensure pyo3 was running in cross compilation mode for cases where PYO3_CROSS_LIB_DIR is getting set in a different part of the build system. There's basically a chain of build systems when I cross compile, buildroot being the meta build system which invokes the setuptools build system which then invokes pyo3 using the cargo build system. So I had added that so at any point cross compilation can be turned on from any build system essentially to ensure one gets a useful error message in the event something in the build chain doesn't set PYO3_CROSS_LIB_DIR. Also added it so that we have a way to force cross compilation without affecting anything else in the event PYO3_CROSS_LIB_DIR gets removed/changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like I missed this in #1514.