Use a non-greedy pattern when capturing modified (#395)

[xoriath]

By making this capture pattern non-greedy it will no longer
capture until the last AM or PM in a directory listing line.

Type of changes

• Bug fix
• New feature
• Documentation / docstrings
• Tests
• Other

Checklist

• I've run the latest black with default args on new code.
• I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
• I've added tests for new code.
• I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #395 by using a non-greedy pattern for capturing the modified time from a NT directory listing (similar as is done for Linux)

Updated the WindowsNT test to catch a regression for this in the future.

 coverage run -m pytest --cov-append .\tests\test_ftp_parse.py
=============================================================================== test session starts =============================================================================== 
platform win32 -- Python 3.7.2, pytest-4.6.5, py-1.8.1, pluggy-0.13.1
Using --randomly-seed=1589597818
rootdir: C:\dev\pyfilesystem2, inifile: setup.cfg
plugins: cov-2.7.1, randomly-3.0.0
collected 5 items                                                                                                                                                                   

tests\test_ftp_parse.py .....                                                                                                                                                [100%] 

============================================================================ 5 passed in 0.20 seconds ============================================================================= ```

[lurch]

The tests pass, so LGTM.

@willmcgugan Slightly off-topic question, but is there a good reason for the inconsistency of having the RE_LINUX using numbered capture-groups but the RE_WINDOWSNT using named capture-groups?

[willmcgugan]

@lurch It's been so long, I'd be guessing. But I reckon I copied those regexes from somewhere.

[xoriath]

So, anything else needed? I don't seem to have merge rights :)

[willmcgugan]

Sorry. There is a back log. Plan to clear it soon.

On Mon, 18 May 2020 at 17:18, Morten Engelhardt Olsen < ***@***.***> wrote: So, anything else needed? I don't seem to have merge rights :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#396 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEHLAM3ZRU4EHB3YBWOJR3RSFNWRANCNFSM4NCXBWJA> .

-- Will McGugan https://www.willmcgugan.com <http://www.willmcgugan.com>

[xoriath]

Hihihi, no problem!

[richardcooper]

I tripped over this bug recently. I'm applying this patch locally and can confirm that it fixes the problem.

[althonos]

@xoriath sorry to bother after such a long time, could you please update the CHANGELOG.md and CONTRIBUTORS.md files so that I can merge this ? Thanks!

[xoriath]

No problem, @althonos , updated the files and rebased to upstream master

[althonos]

Thanks!