Conversation
1ec5
reviewed
Oct 30, 2017
| extension String: Tokenized { | ||
| public var sentenceCased: String { | ||
| return String(characters.prefix(1)).uppercased() + String(characters.dropFirst()) | ||
| return String(self.prefix(1)).uppercased() + String(dropFirst()) |
| extension String: Tokenized { | ||
| public var sentenceCased: String { | ||
| return String(characters.prefix(1)).uppercased() + String(characters.dropFirst()) | ||
| return String(self.prefix(1)).uppercased() + String(dropFirst()) |
Member
There was a problem hiding this comment.
While we wait for CocoaPods/CocoaPods#7134 to be resolved, can we keep both the old and new syntaxes around, guarded by #if swift(>=4)?
added 3 commits
November 20, 2017 10:03
This was referenced Nov 20, 2017
Author
|
@1ec5 this is ready for review. |
1ec5
approved these changes
Nov 20, 2017
Member
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
One minor change, but otherwise good to go.
| extension String: Tokenized { | ||
| public var sentenceCased: String { | ||
| return String(characters.prefix(1)).uppercased() + String(characters.dropFirst()) | ||
| return String(prefix(1)).uppercased() + String(dropFirst()) |
Member
There was a problem hiding this comment.
Substring also has an uppercased() method, so this expression simplifies to:
prefix(1).uppercased() + dropFirst()
1ec5
reviewed
Nov 20, 2017
| [](http://cocoadocs.org/docsets/OSRMTextInstructions/) | ||
|
|
||
| OSRM Text Instructions is a library for iOS, macOS, tvOS, and watchOS applications written in Swift 3 or Objective-C that transforms [OSRM](http://www.project-osrm.org/) route responses into localized text instructions. | ||
| OSRM Text Instructions is a library for iOS, macOS, tvOS, and watchOS applications written in Swift 4 or Objective-C that transforms [OSRM](http://www.project-osrm.org/) route responses into localized text instructions. The last version for Swift 3.2 is `v0.5.0` and the code is also available on the branch [`swift3.2`](). |
added 2 commits
November 20, 2017 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, very few public functions are bridging to obj-c. This was probably the case before this pr.
/cc @1ec5 @frederoni