1404 Fixing a few code performance issues#1423
Merged
wyli merged 6 commits intoProject-MONAI:masterfrom Jan 11, 2021
de-sh:perf-deepsource
Merged
1404 Fixing a few code performance issues#1423wyli merged 6 commits intoProject-MONAI:masterfrom de-sh:perf-deepsource
wyli merged 6 commits intoProject-MONAI:masterfrom
de-sh:perf-deepsource
Conversation
Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: Devdutt Shenoi <devdutt@outlook.in>
Contributor
|
/integration-test |
wyli
approved these changes
Jan 11, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! i didn't check if the changes are exhaustive, but the changed ones are good.
7 tasks
7 tasks
ericspod
pushed a commit
that referenced
this pull request
Apr 4, 2026
### Description
This change probably improves performance slightly (unforetunately, I
don't have a local instance of MONAI installed in order to test this,
but I'm pretty sure from looking at the code that using [], {} and
kwargs_[k] = _get_data(v) should be semantically the same and probably
slightly better in performance, see also #1423 (credits to @de-sh for
the nice fix 👍 ) where at least [] and {} were changed as a refactoring
and kwargs_[k] = _get_data(v) just seems better to me becuase I think
that this saves some time due to dictionary lookups and temporary
objects, but I'm not quite sure because it wasn't tested, so please
correct me if I'm mistaken).
A few sentences describing the changes proposed in this pull request.
### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.
---------
Signed-off-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #1404.
Description
As discussed in the discussion linked above, these issues were detected using the DeepSource static analyzer tool. These issues were specifically tagged and highlighted for their impact on the performance of MONAI, they are:
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.