Merged
Conversation
Adds the new uniques and support for some of their mods Updates the pre-release uniques with their mod rolls
This was referenced Mar 14, 2026
Closed
added 5 commits
March 14, 2026 23:18
Adds a new config option to only show if a condition is true already Moves the flask conditions for HaveAmethystFlask or other base types to CalcSetup as the previous handling in CalcPerform only enabled the condition if the flask was active instead of in the item slot which is what is meant to be for
Adds support for all the shrine mods and also the greater freezing / shocking / skeletal shrine buffs
The Screams of the Desiccated belt only grants you the shrine effects when you do not have any active flask effects Mana and Life flasks with instant effects do not ever count as being under the effect of a flask Same with having a utility flask but having the Bloodline for utility flasks are disabled Added support flasks are instant while on low life and made a helper function in CalcPerform as there are 2 different spots where instPerc are used Tested Vaal Pact and the mana flask mod for effect is instant at end of duration and those both disable the shrine The life flask mod for additional recovery over x seconds does not count as being under a flask effect however
1 task
NDari
pushed a commit
to NDari/PathOfBuilding
that referenced
this pull request
Mar 31, 2026
* Add new 3.28 Uniques Adds the new uniques and support for some of their mods Updates the pre-release uniques with their mod rolls * Desecrated Chalice and Desecrated Chalice flask mods Adds a new config option to only show if a condition is true already Moves the flask conditions for HaveAmethystFlask or other base types to CalcSetup as the previous handling in CalcPerform only enabled the condition if the flask was active instead of in the item slot which is what is meant to be for * Flame of Hope * Screams of the Desiccated Adds support for all the shrine mods and also the greater freezing / shocking / skeletal shrine buffs * Fix while affected by no flasks when using instant flasks The Screams of the Desiccated belt only grants you the shrine effects when you do not have any active flask effects Mana and Life flasks with instant effects do not ever count as being under the effect of a flask Same with having a utility flask but having the Bloodline for utility flasks are disabled Added support flasks are instant while on low life and made a helper function in CalcPerform as there are 2 different spots where instPerc are used Tested Vaal Pact and the mana flask mod for effect is instant at end of duration and those both disable the shrine The life flask mod for additional recovery over x seconds does not count as being under a flask effect however --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9606, Fixes #9621
Description of the problem being solved:
Adds the new uniques and support for some of their mods
Updates the pre-release uniques with their mod rolls
Fix calculations that care about when a flask is active for the Screams of the Desiccated shrine mod
Adds support for all the shrine mods and also the greater freezing / shocking / skeletal shrine buffs
Added support for
flasks are instant while on low lifeand made a helper function in CalcPerform as there are 2 different spots that care about the instant flask percentageMana and Life flasks with instant effects do not ever count as being under the effect of a flask
Same with having a utility flask but having the Bloodline for utility flasks are disabled
Tested Vaal Pact and the mana flask mod for
effect is instant at end of durationand those both disable the shrineThe life flask mod for additional recovery over x seconds does not count as being under a flask effect. Might be a bug and get fixed in the future