Fix Holy Strike Minion missing Lightning damage conversion from skill gem#9578
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom Mar 11, 2026
Merged
Fix Holy Strike Minion missing Lightning damage conversion from skill gem#9578LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
LocalIdentity
changed the title
LocalIdentity
approved these changes
Mar 11, 2026
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
I fixed the PR by adding the required lines to the act_str.txt file.
The lua files are generated from the txt files using the export tool
NDari
pushed a commit
to NDari/PathOfBuilding
that referenced
this pull request
Mar 31, 2026
… gem (PathOfBuildingCommunity#9578) * Fix Holy Strike minion damage conversion calculation * Add export lines --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Holy strike on the current release build does not convert 50% of the minion damage to lightning damage (as shown in the calcs tab when showing minion stats).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/iFpLVAuWKm87
Before screenshot:
After screenshot: