Fix Life/Mana/Hybrid flasks allowing enchantments when crafting#8560
Closed
Blitz54 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Closed
Fix Life/Mana/Hybrid flasks allowing enchantments when crafting#8560Blitz54 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Blitz54 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6127
EDIT: No good, Harvest enchants for all flasks exist. Closing PR as it's a hacky fix that doesn't work if we implement the harvest crafts for Life/Mana Flasks.
See #8224
Description of the problem being solved:
All Flasks showed the Apply Enchantment button. Only Hybrid flasks can have enchantments at this moment.
Before screenshot:
After screenshot: