This repository was archived by the owner on Mar 27, 2020. It is now read-only.
Remove API quota to allow serving large collections of message types#195
Merged
Conversation
remove nancy quota on rest api
tmasternak
force-pushed
the
hotfix-2.1.7
branch
from
75dc00a to
94c1c1f
Compare
mikeminutillo
approved these changes
Feb 26, 2019
Member
mikeminutillo
left a comment
mikeminutillo
left a comment
There was a problem hiding this comment.
Is this a temporary solution or a permanent one? Have we tested to see what the user experience is like when we have 600 handlers in an endpoint?
Member
Author
|
@mikeminutillo good questions. This is one part of the solution, the other involves changing SP. On the SP side, we do a browser side pagination. We tested that setup with 800 message types per endpoint and the performance is acceptable. |
tmasternak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Some of our clients have a lot of message types flowing through single logic instances e.g. 600+. This PR removes quota at Nacy level to make sure that big responses are not truncated and can be properly served to the ServicePulse instances.