This repository was archived by the owner on Mar 27, 2020. It is now read-only.
Fix excessive queue length querying in ASQ#190
Merged
Conversation
SeanFeldman
reviewed
Feb 15, 2019
Contributor
|
Given I don't entirely know what Monitoring is supposed to do and what was it doing that cause the issue, could we chat first? Thanks. |
Co-authored-by: Tomasz Masternak <tomasz.masternak@gmail.com> Co-authored-by: Sean Feldman <feldman.sean@gmail.com>
SeanFeldman
approved these changes
Feb 19, 2019
Contributor
SeanFeldman
left a comment
SeanFeldman
left a comment
There was a problem hiding this comment.
👍
We've briefly discussed a potential optimization for querying, but have decided to let it be as-is and not add extra complexity until either required or reported by customers.
danielmarbach
approved these changes
Feb 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this fix the
sizecollection in theNativeQueueLengthwould grow one entry for each monitoring report received. This, in turn, resulted in excessive storage account usage due to the growing number of queue length queries.Fix
This PR introduces a dedicated class that stores all queue length related variables. This enables having only a single collection for queue length data which helps ensuring that the state of the
NativeQueueLengthdoes not grow indefinitely.