Skip to content
This repository was archived by the owner on Mar 27, 2020. It is now read-only.

Hotifx 2.1.2#181

Merged
Scooletz merged 1 commit into
masterfrom
hotifx-2.1.2
Jan 18, 2019
Merged

Hotifx 2.1.2#181
Scooletz merged 1 commit into
masterfrom
hotifx-2.1.2

Conversation

@Scooletz
Copy link
Copy Markdown
Contributor

@Scooletz Scooletz commented Jan 17, 2019

Fixes #180 by closing properly DataReader that previously was left unclosed.

@Scooletz Scooletz requested a review from a team January 17, 2019 09:31
@Scooletz Scooletz self-assigned this Jan 17, 2019
@Scooletz Scooletz changed the base branch from develop to master January 17, 2019 14:55
@Scooletz
Copy link
Copy Markdown
Contributor Author

Scooletz commented Jan 17, 2019

@tmasternak @mikeminutillo This PR should target master. I changed the target branch.

@Scooletz Scooletz merged commit b2cc9a3 into master Jan 18, 2019
@Scooletz Scooletz deleted the hotifx-2.1.2 branch January 18, 2019 08:41
@Scooletz Scooletz mentioned this pull request Jan 18, 2019
Merged
@danielmarbach danielmarbach mentioned this pull request Jan 23, 2019
Closed
@danielmarbach danielmarbach restored the hotifx-2.1.2 branch January 23, 2019 14:31
@danielmarbach danielmarbach deleted the hotifx-2.1.2 branch February 5, 2019 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mikeminutillo mikeminutillo mikeminutillo approved these changes

@tmasternak tmasternak tmasternak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Scooletz Scooletz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Scooletz @mikeminutillo @tmasternak