feat(channels): add Facebook support#259
feat(channels): add Facebook support#259harshitanand wants to merge 4 commits intoPanniantong:mainfrom
Conversation
|
Thanks for the PR! The channel skeleton is clean and follows project conventions well. However, there are a few issues that need to be addressed before we can merge: 1. Missing 2.
3. Missing Once these are addressed, we'll be happy to merge. Thanks! |
Add FacebookChannel using yt-dlp (public videos) and Jina Reader (text posts) as backends, following the existing channel pattern. - Handles facebook.com, fb.com, and fb.watch URLs - tier-0: yt-dlp is already a project dependency - Registered in ALL_CHANNELS in channels/__init__.py
…ONTRIBUTING compliance)
…ong#171) - check() now returns 'warn' (not 'off') when yt-dlp missing; Jina Reader is always available so the channel is partially functional - Add m.facebook.com to can_handle() for mobile URLs - Add stub read() and search() with NotImplementedError and clear docstrings - Update test: rename off→warn check, add m.facebook.com assertion
6129c1b to
37e8d10
Compare
|
Thanks for the detailed review! Addressed all three points and rebased on latest main:
Tests updated to cover the new |
What
Adds
FacebookChannelusingyt-dlp(public videos) and Jina Reader (text posts) as backends, following the existing channel pattern.Changes
agent_reach/channels/facebook.py— handlesfacebook.com,fb.com, andfb.watchURLs; tier-0 (yt-dlp already a dependency); public videos via yt-dlp, text posts via Jina Readeragent_reach/channels/__init__.py— registersFacebookChannelinALL_CHANNELStests/test_channels.py— addsTestFacebookChannelwithcan_handle(),check()(yt-dlp present/absent), and registry assertionsTesting
TestFacebookChannel— can_handle (facebook.com, fb.com, fb.watch), check ok, check off, registry — PASSEDcan_handle,check,name,description,backends,tier)Related
Closes #171