Merged
Conversation
opencv/cv.h is removed on opencv4 Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
This will change SONAME to libfreenect.so.0 instead of 0.6 Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
Contributor
|
Nice! I think it would be ideal to have both versions as symlinks, like |
Contributor
Author
|
The symlinks are only useful for the unversioned .so to allow the linker to find the appropriate library at link time. It will detect the internal name of the library (SONAME) that also need to have a symlink or it will be created by the system linker at library registration anyway (ldconfig). Others symlinks are not useful to anything and additional symlinks are usually not done across projects (looking at /usr/lib64/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are two patches used by the fedora package.
Fix opencv headers compatible with opencv2+ including OpenCV4 that has dropped support for opencv/cv.h
There is also an issue with the SONAME that integrate the micro version whereas the ABI is compatible with the previous libfreenect 0.5.0. So keep using libfreenect.so.0 instead.