Skip to content

.github/actions: Run Patina QEMU Validation without exiting on Patina test failures#106

Merged
makubacki merged 1 commit into
OpenDevicePartnership:mainfrom
makubacki:patina_qemu_wf_skip_exit_on_patina_test_failure
Mar 18, 2026
Merged

.github/actions: Run Patina QEMU Validation without exiting on Patina test failures#106
makubacki merged 1 commit into
OpenDevicePartnership:mainfrom
makubacki:patina_qemu_wf_skip_exit_on_patina_test_failure

Conversation

@makubacki

@makubacki makubacki commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

Calls directly to patina-dxe-core-qemu cargo-make tasks, are updated to pass --exclude-features exit_on_patina_test_failure.

The --do-not-exit-on-patina-test-failure flag also allows the QEMU validation workflow to continue running even if some Patina tests fail.

Since the build happens and the patina-qemu script is only used for running the build, technically only the cargo-make tasks need to be updated, but both are included in case the script is used for builds in the future.

This is the first step of a series of steps planned to make the patina repository QEMU validation results more robust to transient test failures while also making errors more obvious to developers.

@makubacki makubacki self-assigned this Mar 18, 2026
… test failures

Closes OpenDevicePartnership#100

Calls directly to patina-dxe-core-qemu cargo-make tasks, are updated
to pass `--exclude-features exit_on_patina_test_failure`.

The `--do-not-exit-on-patina-test-failure` flag also allows the QEMU
validation workflow to continue running even if some Patina tests
fail.

Since the build happens and the patina-qemu script is only used for
running the build, technically only the cargo-make tasks need to be
updated, but both are included in case the script is used for builds
in the future.

This is the first step of a series of steps planned to make the
patina repository QEMU validation results more robust to transient
test failures while also making errors more obvious to developers.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the patina_qemu_wf_skip_exit_on_patina_test_failure branch from 872490e to 0236c40 Compare March 18, 2026 23:16
@makubacki makubacki merged commit f6e1632 into OpenDevicePartnership:main Mar 18, 2026
makubacki added a commit that referenced this pull request Mar 18, 2026
… test failures (#106)

Calls directly to patina-dxe-core-qemu cargo-make tasks, are updated to
pass `--exclude-features exit_on_patina_test_failure`.

The `--do-not-exit-on-patina-test-failure` flag also allows the QEMU
validation workflow to continue running even if some Patina tests fail.

Since the build happens and the patina-qemu script is only used for
running the build, technically only the cargo-make tasks need to be
updated, but both are included in case the script is used for builds in
the future.

This is the first step of a series of steps planned to make the patina
repository QEMU validation results more robust to transient test
failures while also making errors more obvious to developers.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Disable QEMU Exits on Patina Test Failures in Patina QEMU PR Validation

3 participants