.github/actions: Run Patina QEMU Validation without exiting on Patina test failures#106
Merged
makubacki merged 1 commit intoMar 18, 2026
Conversation
Javagedes
approved these changes
Mar 18, 2026
os-d
approved these changes
Mar 18, 2026
… test failures Closes OpenDevicePartnership#100 Calls directly to patina-dxe-core-qemu cargo-make tasks, are updated to pass `--exclude-features exit_on_patina_test_failure`. The `--do-not-exit-on-patina-test-failure` flag also allows the QEMU validation workflow to continue running even if some Patina tests fail. Since the build happens and the patina-qemu script is only used for running the build, technically only the cargo-make tasks need to be updated, but both are included in case the script is used for builds in the future. This is the first step of a series of steps planned to make the patina repository QEMU validation results more robust to transient test failures while also making errors more obvious to developers. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
872490e to
0236c40
Compare
makubacki
added a commit
that referenced
this pull request
Mar 18, 2026
… test failures (#106) Calls directly to patina-dxe-core-qemu cargo-make tasks, are updated to pass `--exclude-features exit_on_patina_test_failure`. The `--do-not-exit-on-patina-test-failure` flag also allows the QEMU validation workflow to continue running even if some Patina tests fail. Since the build happens and the patina-qemu script is only used for running the build, technically only the cargo-make tasks need to be updated, but both are included in case the script is used for builds in the future. This is the first step of a series of steps planned to make the patina repository QEMU validation results more robust to transient test failures while also making errors more obvious to developers. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls directly to patina-dxe-core-qemu cargo-make tasks, are updated to pass
--exclude-features exit_on_patina_test_failure.The
--do-not-exit-on-patina-test-failureflag also allows the QEMU validation workflow to continue running even if some Patina tests fail.Since the build happens and the patina-qemu script is only used for running the build, technically only the cargo-make tasks need to be updated, but both are included in case the script is used for builds in the future.
This is the first step of a series of steps planned to make the patina repository QEMU validation results more robust to transient test failures while also making errors more obvious to developers.