Skip to content

fix(scripts): remove dead sonar-report dep and re-enable container cleanup #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheAuditorTool wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −6
Open

fix(scripts): remove dead sonar-report dep and re-enable container cleanup #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions scripts/runSonarQube.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ requireCommand curl
requireCommand docker
requireCommand jq

if ! command -v "sonar-report" &> /dev/null; then
echo "sonar-report is required. Please install it via https://github.com/soprasteria/sonar-report and then try again."
exit 1
fi

# Check for install/updates at https://github.com/SonarSource/sonarqube

container_name="sonarqube-benchmark"
Expand Down Expand Up @@ -91,4 +86,4 @@ mvn exec:java -Dexec.mainClass="org.owasp.benchmark.report.sonarqube.SonarReport

echo "Shutting down SonarQube..."

#docker stop "$container_name"
docker stop "$container_name"
Loading