Skip to content

make runSonarqube.sh to work on LTS9.9#196

Merged
davewichers merged 2 commits intoOWASP-Benchmark:masterfrom
zoobinn:runSonarQubesh-9.9LTS
Jun 13, 2023
Merged

make runSonarqube.sh to work on LTS9.9#196
davewichers merged 2 commits intoOWASP-Benchmark:masterfrom
zoobinn:runSonarQubesh-9.9LTS

Conversation

@zoobinn
Copy link
Copy Markdown
Contributor

@zoobinn zoobinn commented Mar 27, 2023

an attempt to handle JQ errors gracefully, pull all issues and hotspots to populate proper .json results.

zoobinn added 2 commits March 27, 2023 16:22
an attempt to handle JQ errors gracefully, pull all issues and hotspots to populate the .json results.
clean up generated files
@zoobinn
Copy link
Copy Markdown
Contributor Author

zoobinn commented Mar 29, 2023

@davewichers
Copy link
Copy Markdown
Contributor

@darkspirit510 - Can you test this out and let me know if its ready to merge. I know you were working on another pull request for a similar/same? problem.

@darkspirit510
Copy link
Copy Markdown
Contributor

@zoobinn I read this article, too (actually, this was one of the sources for my master thesis 😂).

@davewichers do you think Benchmark should (visually) distinguish between official contributions and those contributed by volunteers without any connection to the actual reader? About your question: I just ran the script and it worked without any problems. Check your mail for the result file. I did some attempt to make SonarQube run on M1, but I never succeeded, so I did not create any PR. This one can be merged.

@davewichers davewichers merged commit 7c587ee into OWASP-Benchmark:master Jun 13, 2023
@davewichers
Copy link
Copy Markdown
Contributor

@davewichers do you think Benchmark should (visually) distinguish between official contributions and those contributed by volunteers without any connection to the actual reader?

There are lots of contributors to Benchmark, both directly from the vendor and from individuals with access to vendor tools. I have. not distinguished between who contributes. So, no. I'm happy to acknowledge contributors, but haven't distinguished between their 'type'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants