buildRustCrate: do not overlay OUT_PATH on src/#78706
Merged
Merged
Conversation
`build.rs` files might create files. Those files are supposed to go into `OUT_DIR` (envirionment variable) and not be overlayed onto the source tree.
Member
Author
|
@GrahamcOfBorg build buildRustCrateTests |
Contributor
|
This should also fix #74071. Just hoping that nothing depends on the old, odd behavior. Good luck! :) |
Member
Author
One of my short-term goals is going to be a |
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
…overlaying buildRustCrate: do not overlay OUT_PATH on src/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
build.rsfiles might create files during theconfigurePhaes. Those files are supposed to go intoOUT_DIR(envirionment variable) and not be overlayed onto the sourcetree. So far we did both. With this change we will only use the
OUT_PATH.fixes #78412
cc @kolloch
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)