fix(bio): unify section heading styles for consistent left alignment#470
fix(bio): unify section heading styles for consistent left alignment#470
Conversation
Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/c6854300-779e-4451-a940-295b87e4f119 Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Pull request overview
Unifies the Bio page section heading markup so all three sections render with the same left-aligned “accent line + title” layout and consistent spacing.
Changes:
- Updated the Technologies heading to match the flex layout + decorative accent line used elsewhere.
- Adjusted the Mini-Game heading bottom margin from
mb-4tomb-6to match the other sections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the 'Technologies' and 'Mini-Game' section headings in src/_includes/bio.njk to ensure visual consistency by adding decorative elements and adjusting margins. Feedback was provided regarding a padding inconsistency between the different section containers that may cause misalignment on larger screens, as well as a suggestion to use a Nunjucks macro to reduce code duplication for these headings.
Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/b12891e7-40a5-416f-8882-415a6b6d877d Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… headings Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/3efa40f9-a3be-4701-9400-ebf98f3ec7b3 Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/2c11c6e7-0b98-4a7d-a1cd-d8238fafb3e8 Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
The pull request updates src/_includes/bio.njk to enhance visual consistency and accessibility. Specifically, it adds aria-hidden="true" to decorative accent lines, standardizes section padding to p-8 sm:p-12, and adjusts the margin for the Mini-Game heading. I have no feedback to provide.
flex items-center gap-2+ accent line to Technologies headingmb-6) on all three headingsp-8 sm:p-12) on Technologies and Mini-Game to match Professional Bioaria-hidden="true"to decorative accent-line spans in all three section headings{% endif %}in Technologies block to match surrounding blocks