Skip to content

Add Nunjucks button to footer#467

Merged
jbampton merged 4 commits intomainfrom
copilot/add-footer-button-for-nunjucks
May 2, 2026
Merged

Add Nunjucks button to footer#467
jbampton merged 4 commits intomainfrom
copilot/add-footer-button-for-nunjucks

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 2, 2026

  • Read Gemini PR review feedback on PR Add Nunjucks button to footer #467
  • Refactor three footer tech buttons into a Nunjucks for loop
  • Add rel="noopener noreferrer" to all three links
  • Add aria-label attributes for accessibility (replaces accessible name; not a duplication)
  • Eleventy dry-run build passes
  • Parallel validation: CodeQL clean, code review comment addressed

@jbampton jbampton added this to the Turbo milestone May 2, 2026
@jbampton jbampton added this to Next May 2, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Next May 2, 2026
@jbampton jbampton moved this from In progress to Review in progress in Next May 2, 2026
@jbampton jbampton requested a review from Copilot May 2, 2026 20:13
@jbampton jbampton marked this pull request as ready for review May 2, 2026 20:13
@jbampton jbampton requested review from BaseMax and jbampton as code owners May 2, 2026 20:13
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a missing Nunjucks attribution button to the footer alongside existing framework/tool buttons, keeping the footer’s “Built with” section consistent with the site’s tech stack.

Changes:

  • Added a new “🔧 Nunjucks” footer link between the existing 11ty and Tailwind links.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/_includes/footer-details.njk Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a link to the Nunjucks documentation in the footer. A security improvement was identified regarding the use of target="_blank" without rel="noopener", which is recommended to prevent potential tabnabbing vulnerabilities.

Comment thread src/_includes/footer-details.njk Outdated
@jbampton jbampton requested a review from Copilot May 2, 2026 20:16
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a link to Nunjucks and includes rel="noopener" attributes to external links in the footer. Feedback suggests refactoring the links into a Nunjucks loop to improve maintainability, adding aria-label attributes for better accessibility, and using rel="noopener noreferrer" for enhanced security and privacy.

Comment thread src/_includes/footer-details.njk Outdated
@jbampton jbampton requested a review from Copilot May 2, 2026 20:47
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the footer links in src/_includes/footer-details.njk by replacing hardcoded anchor tags with a Nunjucks loop. This change introduces a new link for Nunjucks and improves accessibility and security by adding aria-label and rel="noopener noreferrer" attributes to the links. I have no feedback to provide.

@jbampton jbampton merged commit 0fe1add into main May 2, 2026
19 of 20 checks passed
@jbampton jbampton deleted the copilot/add-footer-button-for-nunjucks branch May 2, 2026 20:54
@github-project-automation github-project-automation Bot moved this from Review in progress to Done in Next May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants