Skip to content

Remove YAML file types from includes in biome.json#461

Merged
jbampton merged 2 commits intomainfrom
jbampton-patch-1
May 2, 2026
Merged

Remove YAML file types from includes in biome.json#461
jbampton merged 2 commits intomainfrom
jbampton-patch-1

Conversation

@jbampton
Copy link
Copy Markdown
Member

@jbampton jbampton commented May 2, 2026

https://biomejs.dev/internals/language-support/

Biome does not currently format YAML files but support is in progress

https://biomejs.dev/internals/language-support/

Biome does not currently format YAML files but support is in progress
@jbampton jbampton requested a review from BaseMax as a code owner May 2, 2026 15:16
@jbampton jbampton self-assigned this May 2, 2026
@jbampton jbampton added this to Next May 2, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Next May 2, 2026
@jbampton jbampton added this to the Turbo milestone May 2, 2026
@jbampton jbampton requested a review from Copilot May 2, 2026 15:19
@jbampton jbampton moved this from In progress to Review in progress in Next May 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Biome configuration to stop targeting YAML files, aligning with Biome’s current language support (YAML formatting not yet supported).

Changes:

  • Removed **/*.yaml and **/*.yml from files.includes in biome.json so Biome only targets JSON and Nunjucks templates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the Biome configuration to refine the list of included files. The review identifies that the configuration key used is incorrect (includes instead of include), which leads to the filter being ignored. Additionally, it notes that Nunjucks files are unsupported and suggests including JavaScript and CSS files to align with the project's tech stack.

Comment thread biome.json Outdated
Comment thread biome.json Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread biome.json
@jbampton jbampton merged commit 648f8df into main May 2, 2026
19 of 20 checks passed
@jbampton jbampton deleted the jbampton-patch-1 branch May 2, 2026 15:31
@github-project-automation github-project-automation Bot moved this from Review in progress to Done in Next May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants