Merged
Conversation
fix: errors are raised when emulator lost/found event is raised Whenever androidEmulatorDiscovery raises `emulatorImageFound` or `emulatorImageLost` event, an error is raised in the code as `devicesService` expects to receive an array, but it receives a single image instead. Fix the code in devicesService to handle correctly the event. Also add logic to handle the same events from iOSSimulatorDiscovery. fix: Android emulator images are not correct In case the Android Emulator image does not have displayName set in the config.ini file, the displayName that CLI sets fallbacks to `hw.device.name` property. However, this name is not the one that is visible in other tools, like Android Studio for example. As a user I expect to see the same name as in Android Studio. In order to fix this, fallback to the AvdId value from config.ini file and if it is missing, fallback to `hw.device.name`.
Fatme
approved these changes
Sep 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: errors are raised when emulator lost/found event is raised
Whenever androidEmulatorDiscovery raises
emulatorImageFoundoremulatorImageLostevent, an error is raised in the code asdevicesServiceexpects to receive an array, but it receives a single image instead.Fix the code in devicesService to handle correctly the event. Also add logic to handle the same events from iOSSimulatorDiscovery.
fix: Android emulator image display names are not correct
In case the Android Emulator image does not have displayName set in the config.ini file, the displayName that CLI sets fallbacks to
hw.device.nameproperty.However, this name is not the one that is visible in other tools, like Android Studio for example. As a user I expect to see the same name as in Android Studio.
In order to fix this, fallback to the AvdId value from config.ini file and if it is missing, fallback to
hw.device.name.Here's an image showing the mentioned properties:
NOTE: When displayName has spaces, the AvdId is not the same, however it is much similar than the
hw.device.namepropery: