fix: use pid logcat option only on supported Android devices#3808
Merged
DimitarTachev merged 1 commit intoreleasefrom Aug 8, 2018
Merged
fix: use pid logcat option only on supported Android devices#3808DimitarTachev merged 1 commit intoreleasefrom
pid logcat option only on supported Android devices#3808DimitarTachev merged 1 commit intoreleasefrom
Conversation
rosen-vladimirov
approved these changes
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
No logs are shown for older than 7.0.0 Android Devices (the
adb logcatcall was throwing an exception as the--pidoption is not supported before 7.0.0).What is the new behavior?
We show logs for all Android devices.