Refactor Visual Studio path retrieval and environment variable setup in build script#136
Open
ALIENQuake wants to merge 4 commits intoNVIDIAGameWorks:mainfrom
Open
Refactor Visual Studio path retrieval and environment variable setup in build script#136ALIENQuake wants to merge 4 commits intoNVIDIAGameWorks:mainfrom
ALIENQuake wants to merge 4 commits intoNVIDIAGameWorks:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the Windows build helper script’s Visual Studio discovery and Visual Studio Command Prompt environment setup to support a wider VS version range and simplify vcvars initialization.
Changes:
- Updates
vswhereinvocation to broaden the supported Visual Studio version range and adjust how the installation path is selected. - Reworks the vcvars environment-variable import to run
vcvarsall.batinline and parsecmd’s environment output. - Simplifies the “already configured” check for VS environment variables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I've noticed that the code can be improved. Hopefully changes aren't too big to be merged.