Skip to content

Fix an out of bounds access error#1245

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:release/26.06from
rg20:qp_crash
May 20, 2026
Merged

Fix an out of bounds access error#1245
rapids-bot[bot] merged 2 commits into
NVIDIA:release/26.06from
rg20:qp_crash

Conversation

@rg20
Copy link
Copy Markdown
Contributor

@rg20 rg20 commented May 19, 2026

Description

This PR fixes an out of bound access introduced in #1140

Issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rg20 rg20 requested a review from a team as a code owner May 19, 2026 18:33
@rg20 rg20 requested review from chris-maes and hlinsen May 19, 2026 18:33
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rg20 rg20 added bug Something isn't working non-breaking Introduces a non-breaking change labels May 19, 2026
@rg20 rg20 added this to the 26.06 milestone May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR fixes a dimension mismatch in the barrier solver's initial_point method. The nonnegative_variables mask is now constructed using data.x.size() instead of data.w.size(), ensuring dimensional consistency with the positivity enforcement operation that follows.

Changes

Dimension alignment in initial point

Layer / File(s) Summary
nonnegative_variables mask dimension fix
cpp/src/barrier/barrier.cu
Changed the nonnegative_variables vector construction from data.w.size() to data.x.size() to align mask dimensions with the subsequent data.x.ensure_positive(...) call when free variables are present.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the main change: fixing an out-of-bounds access error in the barrier solver.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly identifies the issue (out of bounds access introduced in #1140) and explains the fix aligns mask dimensions with subsequent operations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@chris-maes chris-maes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @rg20

@rg20
Copy link
Copy Markdown
Contributor Author

rg20 commented May 19, 2026

/ok to test 107ef02

@anandhkb anandhkb added the P0 label May 20, 2026
@rg20
Copy link
Copy Markdown
Contributor Author

rg20 commented May 20, 2026

/ok to test 667a8a1

@rgsl888prabhu rgsl888prabhu changed the base branch from main to release/26.06 May 20, 2026 17:27
@rg20
Copy link
Copy Markdown
Contributor Author

rg20 commented May 20, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 2c64629 into NVIDIA:release/26.06 May 20, 2026
189 of 191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change P0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants