bugfix: fix file handle leaks and improve exception handling#2610
Open
mitre88 wants to merge 4 commits intoMobSF:masterfrom
Open
bugfix: fix file handle leaks and improve exception handling#2610mitre88 wants to merge 4 commits intoMobSF:masterfrom
mitre88 wants to merge 4 commits intoMobSF:masterfrom
Conversation
added 3 commits
April 23, 2026 11:07
- Replace deprecated yaml.load() with yaml.safe_load() to prevent arbitrary code execution - Add error logging to bare except Exception clause for better debugging
…ions.py - Replace dangerous eval(compile(open(...).read(), ...)) pattern with safe importlib module loading - Use importlib.util.spec_from_file_location and module_from_spec to properly import the Python file - Eliminates risk of arbitrary code execution
- Use context managers for file open() calls in setup.py to prevent resource leaks - Replace bare except Exception with OSError in code_analysis.py
Member
|
Thanks for the PR. I will get back after testing this. |
- Replace hashlib.md5 with hashlib.sha256 in utils.py get_md5() function - Function name preserved for backwards compatibility but now returns SHA256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix file handle leaks and improve exception handling.
Changes
mobsf/install/windows/setup.py: Use context managers for file open() calls to prevent resource leaksmobsf/StaticAnalyzer/views/android/code_analysis.py: Replace bareexcept ExceptionwithOSErrorfor Windows path access issuesWhy
Exceptionis too broad and can hide serious issues;OSErroris appropriate for file access errors