fix: fixed the duplicate key issue#6
Open
DebanKsahu wants to merge 3 commits into
Open
Conversation
- `_build_cache_key` directly sorting exclude_patterns and converting them into tuple, this ignoring the duplicate patterns that might be present in `exclude_patterns` list which might cause redundant `GraphCacheKey` generation.
…om `excludes` in `extract_graph()` method. - The reason, apart from `_build_cache_key()` function `exclude` also used by some other private functions also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
_build_cache_keydirectly sorting exclude_patterns and converting them into tuple, this ignoring the duplicate patterns that might be present inexclude_patternslist which might cause redundantGraphCacheKeygeneration.exclude_patternsare removed before sorting and creating the cache key tuple. This helps prevent unnecessary cache misses due to repeated patterns.Change Type