LibWeb: Remove replaced animations per effect target#9271
Open
kalenikaliaksandr wants to merge 1 commit intoLadybirdBrowser:masterfrom
Open
LibWeb: Remove replaced animations per effect target#9271kalenikaliaksandr wants to merge 1 commit intoLadybirdBrowser:masterfrom
kalenikaliaksandr wants to merge 1 commit intoLadybirdBrowser:masterfrom
Conversation
Finished replaceable animations should only be replaced by newer animations that target the same effect target and property. The previous bookkeeping was global per CSS property. This let a finished opacity animation on one element replace a finished opacity animation on another element, dropping the older animation's fill-forwards result. On Duolingo this made the hidden drawer backdrop fall back to its base visible opacity and tint the whole page.
gmta
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished replaceable animations should only be replaced by newer animations that target the same effect target and property.
The previous bookkeeping was global per CSS property. This let a finished opacity animation on one element replace a finished opacity animation on another element, dropping the older animation's fill-forwards result. On Duolingo this made the hidden drawer backdrop fall back to its base visible opacity and tint the whole page.