LibWeb: More animation fixes#9236
Open
Calme1709 wants to merge 8 commits intoLadybirdBrowser:masterfrom
Open
Conversation
This reveals a couple of failing WPT tests which we previously passed by bypassing the cached computed styles.
Various setters on KeyframeEffect didn't invalidate animated style and thus wouldn't be represented in computed style until something else caused an invalidation.
Previously we would only apply animations which were associated with a timeline.
The spec says we should always use the owning element even if the effect's target element has changed
The spec doesn't say what time to use here but in other places where we schedule animation events it says to use "the result of applying the procedure to convert timeline time to origin-relative time to the current time of the timeline with which animation is associated", so we do that here as well. This time is stable per animation frame per timeline so we now correctly fall back to composite ordering of animation/transition events where we previously wouldn't (since the scheduled time was so precise that it was always unique), which causes the imported test to no longer be flakey.
Previously we incorrectly dispatched a "animationstart" event instead of a "transitioncancel" one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes to animations found while working on implementing named scroll timelines. See individual commits for details.