AK: Align UTF-16 string storage#9228
Open
kalenikaliaksandr wants to merge 1 commit intoLadybirdBrowser:masterfrom
Open
AK: Align UTF-16 string storage#9228kalenikaliaksandr wants to merge 1 commit intoLadybirdBrowser:masterfrom
kalenikaliaksandr wants to merge 1 commit intoLadybirdBrowser:masterfrom
Conversation
Align Utf16StringData's UTF-16 flexible storage before it is handed to simdutf for UTF-8 conversion. The previous layout placed the buffer at a 2-byte-aligned offset, so larger vectorized conversions could leave the first code unit corrupted; the Rust parser then saw U+0000 at the start of otherwise valid non-ASCII source and emitted TokenType::Invalid. Add a LibJS regression covering a long source with non-ASCII text, matching the maps.google.com inline-script failure mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Utf16StringData's UTF-16 flexible storage before it is handed to simdutf for UTF-8 conversion. The previous layout placed the buffer at a 2-byte-aligned offset, so larger vectorized conversions could leave the first code unit corrupted; the Rust parser then saw U+0000 at the start of otherwise valid non-ASCII source and emitted TokenType::Invalid.
Add a LibJS regression covering a long source with non-ASCII text, matching the maps.google.com inline-script failure mode.