LibWeb: Implement scrollIntoView for boxes.#9225
Open
dgolebiewski wants to merge 2 commits intoLadybirdBrowser:masterfrom
Open
LibWeb: Implement scrollIntoView for boxes.#9225dgolebiewski wants to merge 2 commits intoLadybirdBrowser:masterfrom
scrollIntoView for boxes.#9225dgolebiewski wants to merge 2 commits intoLadybirdBrowser:masterfrom
Conversation
dgolebiewski
force-pushed
the
scroll-into-view
branch
from
4536edc to
e86c467
Compare
Author
|
Maybe a rebase will please the CI overlords? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
scrollIntoViewwork on regular scrollable boxes. With this change there are 15 more WPT tests passing.This will also help #9060 pass some more WPT tests which fail due to
scrollIntoViewworking only on the viewport.There is still a lot more work to do with supporting different writing directions, but this is a quick win we can take.
Demo:
Nagranie ekranu_20260503_141512.webm