fix: fixed validation of ignore secruity check.#297
Merged
Conversation
Contributor
Author
|
Creating this new PR, because PR opened by customer doesn't contains proper test cases for expected scenarios. |
Contributor
Author
|
@Prashansa-K bumping this up for review. |
Prashansa-K
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH: Kong/deck#2101
Fixes
openapi2kongbehavior where--ignore-security-errorsincorrectly skipped valid OIDC plugin generation.Updated
getOIDCdefaultsso the ignore flag only suppresses unsupported security errors (OR/AND logic, missing scheme, non-OIDC), while still processing validopenIdConnectrequirements.Added regression tests (including mixed supported/unsupported cases) to ensure valid OIDC plugins are generated and invalid security configs are safely ignored.