Feature/query dsl 도입 및 적용하기#433
Open
sososo0 wants to merge 8 commits into
Hidden character warning
The head ref may contain hidden characters: "feature/query_dsl_\uc801\uc6a9"
Open
Conversation
- build.gradle.kts에 query dsl 관련 설정 추가
JPA Factory를 bean 등록하기 위함
spring data jap custom repository 방식 사용
page nation 처리해야 하는 부분은 제외
02ggang9
approved these changes
Mar 21, 2024
|
|
||
| private final JPAQueryFactory jpaQueryFactory; | ||
|
|
||
| @Modifying |
Contributor
There was a problem hiding this comment.
조회를 제외한 쿼리를 직접 작성할 경우에 붙여줘야 하는 걸로 압니다! (맞나용?)
lcqff
approved these changes
Mar 25, 2024
shkisme
approved these changes
Mar 25, 2024
shkisme
left a comment
shkisme
left a comment
Contributor
There was a problem hiding this comment.
수고하셨습니다!!! QueryDSL 드디어 적용... ㅎㅎ👍
Contributor
There was a problem hiding this comment.
gradlew, gradlew.bat 파일들이 올라갔는데 의도하신 건지 궁금합니당!
|
|
||
| private final JPAQueryFactory jpaQueryFactory; | ||
|
|
||
| @Modifying |
Contributor
There was a problem hiding this comment.
조회를 제외한 쿼리를 직접 작성할 경우에 붙여줘야 하는 걸로 압니다! (맞나용?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
📝 Description
Query DSL을 적용하기 위한 설정을 추가했습니다.
일부 Repository의 문자열로 된 query를 Query DSL로 변경하는 작업을 하였습니다.
모든 Repository를 다 변경한 것이 아니라서, 관심 있으신 분들 이어 받아서 작업하시면 될 것 같습니다!
⭐️ Review Request
쿼리를 맞게 수정했는지 꼼꼼하게 확인 부탁드립니다!
쿼리 테스트를 어떻게 하는게 좋을지 고민을 많이 해봤는데, 아직 경험이 없어 잘 모르겠습니다! 추천이나 조언 환영합니다 😄
혹시라도 작동이 안되거나 이 부분이 좀 이상하다!! 싶으면 언제든지 말씀해주세요~!