Return a specific reason in Core 401 responses#407
Closed
swibi-ttd wants to merge 3 commits into
Closed
Conversation
A 401 from /attest (and other auth-gated endpoints) previously returned a bare "Unauthorized", giving operators no way to distinguish a mistyped/unknown key from a disabled key or a role problem. GenericFailureHandler now returns a JSON body with a reason (unrecognized_key / key_disabled / insufficient_role) and an actionable message, inferred from the resolved auth profile. The body surfaces in the operator's attestation log. Adds GenericFailureHandlerTest covering all three reasons and the non-401 passthrough. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
swibi-ttd
force-pushed
the
swi-UID2-7235-meaningful-401
branch
from
b88683b to
c140ece
Compare
Contributor
Author
|
Superseded by #409 — recreating on a clean branch; this branch picked up CI snapshot/merge commits. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A 401 from
/attest(and other auth-gated endpoints) returns a bareUnauthorized. An operator hitting this at startup can't tell a mistyped/unknown key from a disabled key or a missing role, which makes onboarding failures hard to diagnose.Change
GenericFailureHandlernow returns a JSON body on 401 with areasonand an actionablemessage, inferred from the resolved auth profile:unrecognized_keykey_disabledinsufficient_roleThe body propagates into the operator's attestation log, so the cause is visible at the point of failure. Non-401 responses are unchanged.
Tests
GenericFailureHandlerTestcovers all three reasons and the non-401 passthrough.Notes
/attest. It's backward-compatible (callers check the status code; the body is informational) and all Core endpoints authenticate via operator keys, so the wording holds.