Improve Grafana/Loki/Tempo configuration docs with deployment context#2006
Improve Grafana/Loki/Tempo configuration docs with deployment context#2006
Conversation
The Loki and Tempo configuration docs previously assumed Holmes was running inside the Kubernetes cluster: example api_urls used *.svc.cluster.local DNS, and the "find your datasource UID" snippets unconditionally suggested `kubectl port-forward`. This made it hard for users running the Holmes CLI on a laptop (or Holmes outside the cluster) to figure out what URL to put in their config. Add explicit out-of-cluster examples (ingress hostname, external IP, port-forward) alongside the in-cluster ones, and note that the port-forward step is only needed when Grafana isn't already reachable from where the command is being run. Signed-off-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
❌ Deploy Preview for holmes-docs failed. Why did it fail? →
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis pull request updates documentation for Grafana Loki and Grafana Tempo data source integrations. The changes add port-forwarding instructions, configuration examples for in-cluster and out-of-cluster deployments, and introduce X-Scope-OrgID headers to support multi-tenant setups in both proxy and direct connection modes. ChangesData Source Configuration Documentation
Possibly Related PRs
Suggested Reviewers
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Enhanced documentation for Grafana Loki and Tempo data sources to provide clearer guidance on configuring API URLs based on where Holmes is running (in-cluster vs out-of-cluster).
Key Changes
api_urlconfigurations for in-cluster deployments (Kubernetes service URLs) and out-of-cluster scenarios (ingress, external hostnames, port-forwarding)*.svc.cluster.localfrom laptops)Notable Details
https://claude.ai/code/session_011BWhgGStBizzD1vD4Yi5yQ
Summary by CodeRabbit